Fix/430 Refactor: Remove OnceLock statics from TranslatorSv2 (#430)#431
Open
gimballock wants to merge 3 commits intostratum-mining:mainfrom
Open
Fix/430 Refactor: Remove OnceLock statics from TranslatorSv2 (#430)#431gimballock wants to merge 3 commits intostratum-mining:mainfrom
gimballock wants to merge 3 commits intostratum-mining:mainfrom
Conversation
…hotCache::refresh (stratum-mining#337) Move all Prometheus gauge updates (set + stale-label removal) out of the /metrics HTTP handler and into SnapshotCache::refresh(), which runs as a periodic background task. This eliminates the GaugeVec reset gap where label series momentarily disappeared on every scrape. Changes: - SnapshotCache now owns PrometheusMetrics and PreviousLabelSets - refresh() updates snapshot data AND Prometheus gauges atomically - /metrics handler reduced to: set uptime gauge, gather, encode - ServerState simplified (no more PreviousLabelSets or Mutex) - Tests updated to wire metrics through cache via with_metrics() - Integration tests: replace fixed-sleep assertions with poll_until_metric_gte (100ms poll, 5s deadline) for CI resilience - Clone impl preserves previous_labels for correct stale-label detection - debug-level tracing on stale label removal errors - debug_assert on with_metrics double-attachment Closes stratum-mining#337
) Replace process-wide static OnceLock variables (TPROXY_MODE, VARDIFF_ENABLED) with instance fields to fix panics during sequential integration tests. Changes: - Add tproxy_mode and report_hashrate fields to ChannelManager and Sv1Server - Add is_aggregated() and is_non_aggregated() instance methods - Update all call sites to use self.is_aggregated() instead of global functions - Remove static OnceLocks and global helper functions from mod.rs - Add integration test verifying multiple TranslatorSv2 instances can run - Fix test naming mismatch in test_handle_set_target_without_vardiff_non_aggregated This enables multiple TranslatorSv2 instances to be created sequentially without panicking due to OnceLock re-initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace process-wide static OnceLock variables (TPROXY_MODE, VARDIFF_ENABLED)
with instance fields to fix panics during sequential integration tests.
Changes:
This enables multiple TranslatorSv2 instances to be created sequentially
without panicking due to OnceLock re-initialization.